Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment optimization. #249

Merged
merged 1 commit into from
Jun 25, 2019
Merged

comment optimization. #249

merged 1 commit into from
Jun 25, 2019

Conversation

ymh199478
Copy link
Contributor

@ymh199478 ymh199478 commented Jun 25, 2019

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? No
Removed No
Tests pass? Yes
Doc pr? No

The commit optimizes the comments and removes some unnecessary comments

@ymh199478 ymh199478 mentioned this pull request Jun 25, 2019
55 tasks
@codecov-io
Copy link

codecov-io commented Jun 25, 2019

Codecov Report

Merging #249 into master will increase coverage by 0.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   97.23%   97.58%   +0.35%     
==========================================
  Files          35       35              
  Lines        2456     2445      -11     
==========================================
- Hits         2388     2386       -2     
+ Misses         68       59       -9
Impacted Files Coverage Δ
src/CatLib.Core/Support/Arr.cs 98.32% <ø> (ø) ⬆️
src/CatLib.Core/Container/MethodBind.cs 100% <ø> (ø) ⬆️
src/CatLib.Core/CatLib/Facade.cs 94.87% <ø> (ø) ⬆️
src/CatLib.Core/Container/GivenData.cs 100% <ø> (ø) ⬆️
src/CatLib.Core/Container/ExtendContainer.cs 100% <ø> (ø) ⬆️
src/CatLib.Core/Support/Helper.cs 100% <ø> (ø) ⬆️
src/CatLib.Core/Container/ExtendBindData.cs 100% <ø> (ø) ⬆️
src/CatLib.Core/Support/Stream/PipelineStream.cs 76.31% <ø> (ø) ⬆️
src/CatLib.Core/CatLib/Application.cs 99.03% <ø> (+7.88%) ⬆️
src/CatLib.Core/Container/BindData.cs 100% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c8dc45...24f5e77. Read the comment docs.

@ymh199478 ymh199478 merged commit 349e70d into master Jun 25, 2019
@ymh199478 ymh199478 deleted the changed/free-comment branch June 25, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants